Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of pipeACK #4190

Merged
merged 5 commits into from
Oct 13, 2020
Merged

Remove mention of pipeACK #4190

merged 5 commits into from
Oct 13, 2020

Conversation

ianswett
Copy link
Contributor

@ianswett ianswett commented Oct 12, 2020

Fixes #4178 by removing a paragraph mentioning pipeACK and moving RFC3168 to a normative reference.

@ianswett ianswett added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels Oct 12, 2020
draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
determine if the congestion window is sufficiently utilized.
A sender can use a variety of mechnaisms to determine if the congestion window
is sufficiently utuilized. For example, the pipeACK method described in
Section 4.3 of {{?RFC7661}}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually rephrase this part completely (or maybe just remove it entirely as there is another reference two paragraphs down). RFC7661 mainly uses the term "application-limited", however, it does not really propose a mechanism to exactly detect that a connection is application-limited, but rather proposes additional mechanism to even decrease the congestion window when no validated. It further says that the cwnd window MUST NOT be increase when not cwnd-limited and that cwnd-limitation is detected based on FlightSize (or other mechanism, see also section 4.5.3 of RFC7661) as also described in the previous paragraph in the recovery draft:

A sender that is not cwnd-limited MUST NOT increase the cwnd
         when ACK packets are received in this phase 

So I don't think RFC7661 actually provides any different meachanism to detect if the cwnd is sufficiently utilised.

Please note also that RFC7661 actually says MUST NOT while the QUIC recovery draft has only a SHOULD NOT...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll remove this paragraph.

ianswett and others added 3 commits October 12, 2020 10:35
Co-authored-by: mirjak <mirja.kuehlewind@ericsson.com>
Co-authored-by: mirjak <mirja.kuehlewind@ericsson.com>
@ianswett ianswett changed the title Clarify that pipeACK is an example Remove mention of pipeACK Oct 12, 2020
@ianswett ianswett removed the editorial An issue that does not affect the design of the protocol; does not require consensus. label Oct 12, 2020
I'm not sure if all of them need to be normative or not?
@janaiyengar janaiyengar added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Oct 13, 2020
@janaiyengar janaiyengar merged commit 6ed1fcc into master Oct 13, 2020
@janaiyengar janaiyengar deleted the ianswett-pipeack-example branch October 13, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recovery-31: Normative References
5 participants