Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial PTO is 3*kInitialRtt, not 2*kInitialRtt #4262

Closed
wants to merge 1 commit into from
Closed

Initial PTO is 3*kInitialRtt, not 2*kInitialRtt #4262

wants to merge 1 commit into from

Conversation

ianswett
Copy link
Contributor

Fixes #4261

martinthomson
martinthomson requested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the concept of initial timeout isn't valid and would prefer this uses the PTO on the newly initialized path instead. Otherwise, we don't factor in the maximum ack delay.

@ianswett
Copy link
Contributor Author

I believe this PR is consistent with the recovery doc, but I'd be open to other suggestions.

martinthomson added a commit that referenced this pull request Oct 27, 2020
@martinthomson
Stop using initial timeout
2719b29 
Address validation can use 3*PTO, just taking the maximum of the old and
new path PTO.  The idea of initial timeout is easily replaced in
recovery by instead describing the effect on the PTO.  The net effect is
the same, except that new paths often have to include the maximum ACK
delay, which this doesn't incorporate.

Closes #4261.
Closes #4262.
@martinthomson martinthomson mentioned this pull request Oct 27, 2020
Merged
@martinthomson
Copy link
Member

Check out #4263.

@kazuho kazuho mentioned this pull request Oct 28, 2020
Closed
martinthomson added a commit that referenced this pull request Nov 4, 2020
@martinthomson
Stop using initial timeout
af48a3d 
Address validation can use 3*PTO, just taking the maximum of the old and
new path PTO.  The idea of initial timeout is easily replaced in
recovery by instead describing the effect on the PTO.  The net effect is
the same, except that new paths often have to include the maximum ACK
delay, which this doesn't incorporate.

Closes #4261.
Closes #4262.
@martinthomson martinthomson deleted the ianswett-initial-rtt branch November 5, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson requested changes

@kazuho kazuho kazuho approved these changes

@janaiyengar janaiyengar Awaiting requested review from janaiyengar

Assignees
No one assigned
Labels
-transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial timeout in path validation failure
3 participants
@ianswett @martinthomson @kazuho