Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the 3x amplification-limit to migration too #4264

Merged
merged 21 commits into from Dec 10, 2020

Commits on Oct 28, 2020

  1. Add a blanket 3x anti-amplification limit

    This touches a lot of places in the document, but I think that the
    changes are all fairly minor.
    
    The major cnahge here is a move to a uniform 3x limit on sending
    packets toward unvalidated addresses.  Specifically, this applies when
    the packets are sent in response to another packet.  In practice, this
    means that only servers are affected by this.
    
    The consequence of this change is that PATH_CHALLENGE won't always be
    padded, as previously agreed.  That also means that PATH_RESPONSE might
    not be as well (if the client migrates, it can send PATH_CHALLENGE in
    that packet; though we require that to be padded, we specifically don't
    require enforcement, so...).  Address validation using this packet
    works, but this doesn't also provide MTU validation.  To fix that, I
    have recommended that a second validation be performed when the address
    is valid, or there are enough bytes available that the
    anti-amplification limit is not a barrier.
    
    The nice part about this is that unifies the response.  We no longer
    have weird carve-outs for rate limiting or minimum congestion window
    (both of which I removed as part of this).
    
    Closes #4257.
    martinthomson committed Oct 28, 2020
    Copy the full SHA
    51423d0 View commit details
    Browse the repository at this point in the history
  2. Some stuff I missed

    martinthomson committed Oct 28, 2020
    Copy the full SHA
    3bf6b2f View commit details
    Browse the repository at this point in the history
  3. MUST be consistent

    martinthomson committed Oct 28, 2020
    Copy the full SHA
    97ba8a6 View commit details
    Browse the repository at this point in the history
  4. Small corrections

    Co-authored-by: Eric Kinnear <ekinnear@users.noreply.github.com>
    martinthomson and ekinnear committed Oct 28, 2020
    Copy the full SHA
    59f5a3a View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    2df832a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Make it clearer

    Co-authored-by: Mike Bishop <mbishop@evequefou.be>
    martinthomson and MikeBishop committed Oct 29, 2020
    Copy the full SHA
    549564f View commit details
    Browse the repository at this point in the history
  2. Wrap stuff

    martinthomson committed Oct 29, 2020
    Copy the full SHA
    8c0c1f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. Jana's comments

    martinthomson committed Nov 4, 2020
    Copy the full SHA
    fb033df View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    fb253e9 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    66b7c2a View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    593d552 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Add an error code for when the path fails

    This is a bit of a niche code, as it is only narrowly useful for
    signaling loss of paths.  But people wanted it and it doesn't code that
    much.
    
    For #4257.
    martinthomson committed Nov 5, 2020
    Copy the full SHA
    4769dbe View commit details
    Browse the repository at this point in the history
  2. moar

    Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
    martinthomson and janaiyengar committed Nov 5, 2020
    Copy the full SHA
    3527972 View commit details
    Browse the repository at this point in the history
  3. Fewer words = good

    Co-authored-by: Mike Bishop <mbishop@evequefou.be>
    martinthomson and MikeBishop committed Nov 5, 2020
    Copy the full SHA
    2ffb2ab View commit details
    Browse the repository at this point in the history
  4. Merge pull request #4331 from quicwg/no-viable-path

    Add an error code for when the path fails
    martinthomson committed Nov 5, 2020
    Copy the full SHA
    bbc0711 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. use parentheses for adjunct citations

    Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
    martinthomson and janaiyengar committed Nov 6, 2020
    Copy the full SHA
    54f48ce View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Copy the full SHA
    fae20ab View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    3e5b0fd View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Copy the full SHA
    8324d82 View commit details
    Browse the repository at this point in the history
  2. gramma

    Co-authored-by: David Schinazi <DavidSchinazi@users.noreply.github.com>
    martinthomson and DavidSchinazi committed Dec 10, 2020
    Copy the full SHA
    c549aee View commit details
    Browse the repository at this point in the history
  3. Suggestion

    martinthomson committed Dec 10, 2020
    Copy the full SHA
    07989a2 View commit details
    Browse the repository at this point in the history