Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A zero-length connection ID is always good #4335

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Conversation

martinthomson
Copy link
Member

For all packets. For all network paths.

For all packets.  For all network paths.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Nov 5, 2020
Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good to call out this implicit exception.

An endpoint that selects a zero-length connection ID during the handshake
cannot send a NEW_CONNECTION_ID frame. A zero-length Destination Connection ID
field is used for all packets sent toward such an endpoint and for all network
paths.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to clarify that the scope is for that connection in the second sentence.

Suggested change
paths.
paths for the remainder of the connection.

Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor comments

draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@janaiyengar janaiyengar merged commit c93f251 into master Nov 10, 2020
@janaiyengar janaiyengar deleted the migrate-zero-length branch November 10, 2020 04:45
An endpoint that selects a zero-length connection ID during the handshake
cannot issue a new connection ID. A zero-length Destination Connection ID
field is used in all packets sent toward such an endpoint over any network
path.
Copy link
Contributor

@mirjak mirjak Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I know this has been merged already but I thought this is easier than open a new issue.

How can you use a connection with zero-length Conn ID over different paths? Doesn't an address change without Conn ID mean that the connections breaks?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peer could still change its address, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have changed the address and don't have a conn ID, you cannot associate the packet to an existing connection anymore, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. You can still associate it in theory, though it might be fragile - this is left to the implementation ultimately. I agree with you that the "over any network path" is mostly redundant, but I am not sure that it hurts because I don't think it suggests something that is impossible.

@mirjak
Copy link
Contributor

mirjak commented Dec 4, 2020

You are right it's not really incorrect , I just found it confusing giving potentially the impression that using multiple paths without CID is "easily" possible. How about this phrasing to be even more clear:

"A zero-length Destination Connection ID
field is used in all packets sent toward such an endpoint and this cannot be changed even if the network
path changes."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants