Clarify labels example in -tls Appendix A.1. #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove any possible ambiguity from the first sentence of the A.1. sub-section. Signed-off-by: Paul Mabileau <paulmabileau@hotmail.fr>
martinthomson
added
-tls
editorial
martinthomson
approved these changes
Nov 20, 2020
|
Ok, that is another tools.ietf.org failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
We are currently in an effort of implementing QUIC in the Scapy packet manipulation library. While doing so, we've had a few moments of doubts as to what was the intention or simply the true meaning behind various parts of the specification. One of them was the first sentence of the appendix A.1. of the QUIC-TLS draft: it lead us to think that the results listed below were the output of the
HKDF-Expand-labelfunction instead of the labels built during its execution and then given toHKDF-Expandto obtain the final result.This PR thus proposes a small change in order to remove any possible ambiguity from that first sentence. If you have any remark or suggestion regarding typos, grammar, wording or additional clarifications required, please let us know.
Hope it helps.
Cheers,
Paul.