Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always save the packet size and return early #4409

Merged
merged 4 commits into from Nov 26, 2020
Merged

Always save the packet size and return early #4409

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77217e1
Always save the packet size and return early
ianswett Nov 25, 2020
2a62624
Update draft-ietf-quic-recovery.md
ianswett Nov 25, 2020
a435847
Update draft-ietf-quic-recovery.md
ianswett Nov 25, 2020
bffe282
Add an assert
ianswett Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -1335,12 +1335,11 @@ OnPacketSent(packet_number, pn_space, ack_eliciting,
sent_packets[pn_space][packet_number].ack_eliciting =
ack_eliciting
sent_packets[pn_space][packet_number].in_flight = in_flight
sent_packets[pn_space][packet_number].sent_bytes = sent_bytes
if (in_flight):
if (ack_eliciting):
time_of_last_ack_eliciting_packet[pn_space] = now()
OnPacketSentCC(sent_bytes)
sent_packets[pn_space][packet_number].sent_bytes =
sent_bytes
SetLossDetectionTimer()
~~~

Expand Down Expand Up @@ -1717,8 +1716,8 @@ Whenever a packet is sent, and it contains non-ACK frames, the packet
increases bytes_in_flight.

~~~
OnPacketSentCC(bytes_sent):
bytes_in_flight += bytes_sent
OnPacketSentCC(sent_bytes):
bytes_in_flight += sent_bytes
~~~


Expand All @@ -1740,6 +1739,8 @@ OnPacketsAcked(acked_packets):
OnPacketAcked(acked_packet)

OnPacketAcked(acked_packet):
if (!acked_packet.in_flight):
return;
// Remove from bytes_in_flight.
bytes_in_flight -= acked_packet.sent_bytes
// Do not increase congestion_window if application
Expand Down Expand Up @@ -1804,6 +1805,7 @@ Invoked when DetectAndRemoveLostPackets deems packets lost.
OnPacketsLost(lost_packets):
// Remove lost packets from bytes_in_flight.
for lost_packet in lost_packets:
assert(lost_packet.in_flight)
bytes_in_flight -= lost_packet.sent_bytes
OnCongestionEvent(lost_packets.largest().time_sent)

Expand Down