Always save the packet size and return early #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the packet is not in_flight, return early instead of not saving the size earlier. FIxes #4408
janaiyengar
requested changes
Nov 25, 2020
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
Only in_flight packets are added to lost_packets, so adding an assert to improve readability.
|
We already have a check to only add in_flight packets to lost_packets, but I added an assert to hopefully make that clearer. |
janaiyengar
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
I think symmetry here would have been clearer -- if all lost packets were in the list, similar to acked packets, and if the check for inflight was at the time of removing it from bytes_in_flight. That does make the code for OnPacketsLost more complicated though, since you have to do an early return if none of the packets lost were in flight. On balance, I think the assert is good enough -- thanks!
martinthomson
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the packet is not in_flight, return early instead of not saving the size earlier.
FIxes #4408