Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change packet number encoding example #4840

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

martinthomson
Copy link
Member

For a reason I didn't bother to investigate this was wrong.

@MikeBishop, please double check. Anyone else who wants to double
check, the extra effort would be appreciated.

For a reason I didn't bother to investigate this was wrong.

@MikeBishop, please double check.  Anyone else who wants to double
check, the extra effort would be appreciated.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Mar 17, 2021
@larseggert
Copy link
Member

Is there an issue associated with this?

@martinthomson martinthomson linked an issue Mar 17, 2021 that may be closed by this pull request
@MikeBishop
Copy link
Contributor

This appears to check out, but obviously my math is suspect, having written the original example. :-)

@bradfordwetmore
Copy link

I am the person who pointed this out to @MikeBishop last night. These new numbers look correct to me.

Note, I am not involved with the draft writing, so can't approve this change.

Thanks for addressing.

@martinthomson
Copy link
Member Author

Whether or not you can approve, I value the extra validation. At this stage, we can't afford to make this sort of mistake. And Mike, it's on me as much as you for not checking your numbers originally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples of packet number encoding are wrong
4 participants