Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of initial_rtt variable #531

Merged
merged 3 commits into from
May 17, 2017
Merged

Remove use of initial_rtt variable #531

merged 3 commits into from
May 17, 2017

Conversation

janaiyengar
Copy link
Contributor

Closes #525

Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except one nit.

@@ -412,7 +408,8 @@ below shows how the single timer is set based on the alarm mode.
The initial flight has no prior RTT sample. A client SHOULD remember
the previous RTT it observed when resumption is attempted and use that for an
initial RTT value. If no previous RTT is available, the initial RTT defaults
to 200ms. Once an RTT measurement is taken, it MUST replace initial_rtt.
to 200ms. Once an RTT measurement is taken, it MUST replace the initial RTT
value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this now, I think we can remove this last sentence.

@janaiyengar janaiyengar merged commit 5a7ca26 into master May 17, 2017
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels May 22, 2017
@martinthomson martinthomson deleted the initial_rtt branch June 16, 2017 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants