Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nits in SetLossDetectionAlarm pseudo code #525

Closed
larseggert opened this issue May 16, 2017 · 0 comments
Closed

Nits in SetLossDetectionAlarm pseudo code #525

larseggert opened this issue May 16, 2017 · 0 comments
Assignees
@janaiyengar
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@larseggert
Copy link
Member

A few things:

  • I think the initial_rtt variable can be removed, since it is only ever assigned the kDefaultInitialRtt default, so it can be replaced by that constant in the pseudo code for SetLossDetectionAlarm.

  • There are two places where alarm_duration is left-shifted in the pseudo code for SetLossDetectionAlarm. That operation assumes an integer representation of alarm_duration; suggest to replace that with multiplication.
@larseggert larseggert added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels May 16, 2017
@janaiyengar janaiyengar mentioned this issue May 16, 2017
Merged
@ianswett ianswett assigned ianswett and janaiyengar and unassigned ianswett May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janaiyengar janaiyengar

Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@larseggert @janaiyengar @ianswett