Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require the client to detect partly bogus version negotiation packets #593

Closed
wants to merge 1 commit into from
Closed

Require the client to detect partly bogus version negotiation packets #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,10 @@ proceeds with the handshake ({{handshake}}). This commits the server to the
version that the client selected.

When the client receives a Version Negotiation packet from the server, it should
select an acceptable protocol version. If the server lists an acceptable
select an acceptable protocol version. If the packet contains the version that
the client initially offered, the client MUST terminate the connection
using a QUIC_INVALID_VERSION_NEGOTIATION_PACKET error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not currently possible to send that error code. (See #467.)

It might be better to just consider QUIC to have failed in this case.

If the server lists an acceptable
version, the client selects that version and reattempts to create a connection
using that version. Though the contents of a packet might not change in
response to version negotiation, a client MUST increase the packet number it
Expand Down