Refer to all header octets by number #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
-transport
editorial
martinthomson
changed the title
ianswett
reviewed
Jun 27, 2017
draft-ietf-quic-transport.md
Outdated
| @@ -461,24 +461,24 @@ This header form has the following fields: | |||
|
|
|||
| Header Form: | |||
|
|
|||
| : The most significant bit (0x80) of the first octet of a packet is the header | |||
| : The most significant bit (0x80) of the octet 0 of a packet is the header | |||
There was a problem hiding this comment.
This text is a bit redundant to the "Header Form" section above, and the sentence is a bit awkward. Can you just say "The most significant bit (0x80) of octet 0 is set to 0 for the short header."?
draft-ietf-quic-transport.md
Outdated
| form. This bit is set to 0 for the short header. | ||
|
|
||
| Connection ID Flag: | ||
|
|
||
| : The second bit (0x40) of the first octet indicates whether the Connection ID | ||
| : The second bit (0x40) of the octet 0 indicates whether the Connection ID |
There was a problem hiding this comment.
nit: I'd change "the octet 0" to "octet 0", here and below.
martinthomson
force-pushed
the
first-octet
branch
from
2ad5aeb
to
7ac6523
Compare
ianswett
approved these changes
Jun 28, 2017
draft-ietf-quic-transport.md
Outdated
|
|
||
| Long Packet Type: | ||
|
|
||
| : The remaining seven bits of first octet of a long packet is the packet type. | ||
| This field can indicate one of 128 packet types. The types specified for this | ||
| : The remaining seven bits of octet 0 of a long packet is the packet type. This |
There was a problem hiding this comment.
I think "of a long packet" is redundant given "Long Packet Type:" is the title as well, and it makes the sentence a bit awkward.
martinthomson
force-pushed
the
first-octet
branch
from
e135688
to
d325ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580