Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport Section 5.1 enumeration of Octets appear off #580

Closed
gloinul opened this issue Jun 5, 2017 · 0 comments
Closed

Transport Section 5.1 enumeration of Octets appear off #580

gloinul opened this issue Jun 5, 2017 · 0 comments
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@gloinul
Copy link
Contributor

gloinul commented Jun 5, 2017

In draft-ietf-quic-transport-03 in section 5.1:

Header Form: The most significant bit (0x80) of the first octet is
set to 1 for long headers and 0 for short headers.

Long Packet Type: The remaining seven bits of first octet of a long
packet is the packet type. This field can indicate one of 128
packet types. The types specified for this version are listed in
Table 1.

Connection ID: Octets 1 through 8 contain the connection ID.
Section 5.7 describes the use of this field in more detail.

Packet Number: Octets 9 to 12 contain the packet number. {{packet-
numbers} describes the use of packet numbers.

Version: Octets 13 to 16 contain the selected protocol version.
This field indicates which version of QUIC is in use and
determines how the rest of the protocol fields are interpreted.

Payload: Octets from 17 onwards (the rest of QUIC packet) are the
payload of the packet.

As the fields connection ID etc follows a first octet (Header form and Long Packet Type), the enumeration appears to be off by one. At least using the construction "Octets 1 through 8" implies at least to this reader that this is the first to eight octets, not the second to ninth which it really is. Please edit so that there are no risk for contradictions here.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jun 5, 2017
martinthomson added a commit that referenced this issue Jun 21, 2017
martinthomson added a commit that referenced this issue Jun 27, 2017
martinthomson added a commit that referenced this issue Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

2 participants