Servers SHOULD NOT misuse the CANCELLED state #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2017
Closed
martinthomson
approved these changes
Sep 11, 2017
| @@ -767,14 +767,20 @@ indicated in the GOAWAY frame, those requests were not and will not be | |||
| processed. Endpoints SHOULD reset any streams above this ID with the error code | |||
| HTTP_REQUEST_CANCELLED. Servers MAY also reset streams below the indicated ID | |||
| with HTTP_REQUEST_CANCELLED if the associated requests were not processed. | |||
| Servers MUST NOT use the HTTP_REQUEST_CANCELLED status for requests which were | |||
| partially or fully processed. | |||
There was a problem hiding this comment.
Clients can detect this by observing that it received part of a response. Do you want to recommend a reaction for clients?
There was a problem hiding this comment.
Following paragraph discusses what clients do with cancelled requests and this PR adds, "However, if a stream is cancelled after receiving a partial response, the response SHOULD NOT be used and the request cannot be safely retried."
Though rereading it, it might be clearer to place the addition before the existing last sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #757. Servers shouldn't cancel / send GOAWAY with a value less than a stream that started getting a response. Clients SHOULD discard responses when servers do this, unless the response was complete. (Blowing up seems kind of pointless when the connection is winding down anyway.)
This really feels like a case of "If it hurts, don't do it." Suggestions on tightening the text appreciated.