require ACKs and allow PADDING in the Server Stateless Retry packet #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not in favor of this for the reasons discussed in #879, so we should discuss before merging. |
janaiyengar
reviewed
Oct 31, 2017
nibanks
approved these changes
Feb 28, 2018
draft-ietf-quic-transport.md
Outdated
| on stream 0 with offset 0 containing the server's cryptographic stateless retry | ||
| material. It MUST NOT contain any other frames. The next STREAM frame sent by | ||
| the server will also start at stream offset 0. | ||
| The payload of the Retry packet contains a STREAM frame on |
There was a problem hiding this comment.
I don't think the first two lines here should be changed. Maybe this is just out of date?
|
This PR needs to be re-targeted to cover the new scope of #627, but it's otherwise good. |
See discussion in quicwg#627 for the stronger language for ACK frames. Closes quicwg#1067. Updates quicwg#627.
|
Ugh, sorry @marten-seemann -- I meant to send a patch to your commit, but ended up committing to your branch instead. Take a look, and respond if you think it's fine. I'm happy to merge if you agree. |
janaiyengar
changed the title
... RTT measurement is a bonus.
marten-seemann
commented
Mar 15, 2018
draft-ietf-quic-transport.md
Outdated
| The payload of the Retry packet contains at least two frames. It MUST include a | ||
| STREAM frame on stream 0 with offset 0 containing the server's cryptographic | ||
| stateless retry material. It MUST also include an ACK frame to acknowledge the | ||
| client's Initial packet. It MAY additionally include one ore more PADDING |
|
LGTM. |
janaiyengar
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1067. Updates #627.