Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry packet and PADDING #1067

Closed
larseggert opened this issue Jan 24, 2018 · 3 comments
Closed

Retry packet and PADDING #1067

larseggert opened this issue Jan 24, 2018 · 3 comments
Assignees

Comments

@larseggert
Copy link
Member

-08 in Section 5.4.2. says:

The payload of the Retry packet contains a single STREAM frame on
stream 0 with offset 0 containing the server's cryptographic
stateless retry material. It MUST NOT contain any other frames. The
next STREAM frame sent by the server will also start at stream offset
0.

Any reason why PADDING is not allowed? (Insert usual stuff about zero-copy and fixed offsets.)

@marten-seemann
Copy link
Contributor

There’s a related PR for this: #882

@larseggert
Copy link
Member Author

#882 says "It SHOULD also contain an ACK frame" and removes the limit on any other frames. That looks a bit too broad?

Why not say "MAY contain PADDING (and ACK?) and MUST NOT..."

@MikeBishop
Copy link
Contributor

#882 doesn't say anything about PADDING, and should perhaps also pad to the minimum handshake packet size (so it fails quickly if the network won't work). We should get this as part of updating it to cover #627.

janaiyengar added a commit to marten-seemann/base-drafts that referenced this issue Mar 15, 2018
See discussion in quicwg#627 for the stronger language for ACK frames.

Closes quicwg#1067. Updates quicwg#627.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants