-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUIC-TLS Extension and version negotiation #99
Conversation
I think that this is better off moved to the -transport document. If it's OK with you, I plan to move your text there. I think that keeps the separation of concerns cleaner. |
I kind of disagree -- I was trying to keep anything TLS-specfic out of the Transport doc. Remember that QUIC doesn't know that the crypto protocol is necessarily TLS. Defining that any handshake MUST be able to transport a blob and then defining how TLS will transport the opaque data keeps the components separate. |
Actually, I made that comment without really reading what you had done. I prefer this structure. I've built on and fleshed it out more in #122. |
MUST abort the connection. A client MUST abort a connection if the server picks | ||
an incompatible version of QUIC version and ALPN. | ||
If the server cannot select a compatible combination of ALPN identifier and QUIC | ||
version, it MUST abort the connection. A client MUST abort a connection if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this specify which error to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, generally we need to identify error codes. But until we have #37 fixed, I think that we can afford to be a little bit lenient on PRs that describe error conditions.
Since we have #122 and this is bitrotten, closing this. |
Proposal on how to define the TLS extension for QUIC, and thereby fix up some of the version negotiation issues (#89, #97).
Key changes: