-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[+] Explicit Path ID: Clarify that endpoints use the same Path ID in both directions. #315
Merged
Merged
Changes from 18 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
d1d6c6e
[+] Clarify that endpoints use the same Path ID for one specific path…
Yanmei-Liu a20fadb
[+] specify PATH_ABANDON cause all the CID allocated for the Path ID …
Yanmei-Liu 34594ef
Update draft-ietf-quic-multipath.md
Yanmei-Liu 4926786
Update draft-ietf-quic-multipath.md
Yanmei-Liu cab06c3
Update draft-ietf-quic-multipath.md
Yanmei-Liu e28e10e
[+] Clarify that endpoints use the same Path ID for one specific path…
Yanmei-Liu b74c5ae
[+] specify PATH_ABANDON cause all the CID allocated for the Path ID …
Yanmei-Liu fdbb95a
Update draft-ietf-quic-multipath.md
Yanmei-Liu 982c03c
Update draft-ietf-quic-multipath.md
Yanmei-Liu aea4f81
Update draft-ietf-quic-multipath.md
Yanmei-Liu 83b0725
Merge branch 'dev/path_id_for_both_direction' of https://github.com/q…
Yanmei-Liu 0cdd559
Update draft-ietf-quic-multipath.md
Yanmei-Liu d7426a2
Merge branch 'main' into dev/path_id_for_both_direction
mirjak 6c02f5e
fix-lint
mirjak 479de5e
Update draft-ietf-quic-multipath.md
mirjak 323f3cf
nits/typos
mirjak 1dddecb
Update draft-ietf-quic-multipath.md
Yanmei-Liu d877959
Update draft-ietf-quic-multipath.md
Yanmei-Liu d20519b
whitespace
mirjak a77525b
Move text to initiation section
mirjak 7f6c5b4
Merge branch 'main' into dev/path_id_for_both_direction
mirjak 6bf2d85
Update draft-ietf-quic-multipath.md
mirjak 6c8ea03
Update draft-ietf-quic-multipath.md
mirjak 62d3678
Editorial clean up
mirjak 60cf3fc
Update intro
mirjak f06069c
whitespace
mirjak 06c8297
Update draft-ietf-quic-multipath.md
mirjak 5bf27b0
Update draft-ietf-quic-multipath.md
mirjak b712f6b
Update draft-ietf-quic-multipath.md
Yanmei-Liu ed01cd8
Update draft-ietf-quic-multipath.md
Yanmei-Liu 30a56a5
Update draft-ietf-quic-multipath.md
mirjak 6af816c
Update draft-ietf-quic-multipath.md
mirjak 46b44c3
Move sentence and editorial fixes
mirjak b22dbae
restructure path close section
mirjak 902ab71
Update draft-ietf-quic-multipath.md
mirjak a865fea
whitespace
mirjak File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the client should only try to open a path if it had send CIDs for that path ID (and the reception has been ack'ed). Then if the server received a path challenges for a path ID it doesn't have a CID for, it should either be an error or it should send a path abandon on another path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could be in the situation where the server has sent MP_NEW_CONNECTION_ID frames to the client, and the client wants to open a new path by sending a PATH_CHALLENGE along with a MP_NEW_CONNECTION_ID frame with the associated Path ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sending it in the same packet is fine as well because than it cannot be lost or reordered separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this issue is not resolved because if you send it in the same packet, it's "just" a matter of processing it the right order. However, otherwise I don't think it's a good idea to save the path challenge for later because then you also have to specify how long to wait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this text for now. I will create a separate PR (and issue) for this as soon as we have merged this PR.