Use native scrollIntoView method so it correctly accounts for paddings and scroll-margins #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and scroll-margin / scroll-padding
|
This looks like a great change! It looks like some of the tests/linters failed, but they might be fixed just by using |
|
@csculley linted and version bumped 👍 |
|
On second thought, maybe this could be just a patch version, but I'm not sure it matters too much. I've requested for some reviews, but this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DIY scroll into view calculations don't correctly account for paddings and scroll-margins. By using the native scrollInfoView method elements won't be clipped when they are styled by the users.