ElasticSearch queries #2088
Merged
ElasticSearch queries #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexei Mochalov <nl.imbecile@gmail.com>
…ilt into es-queries-run-async-result
fiskus
commented
Mar 10, 2021
catalog/package.json
Outdated
| @@ -79,6 +80,7 @@ | |||
| "invariant": "^2.2.4", | |||
| "ip": "^1.1.5", | |||
| "js-yaml": "^3.14.1", | |||
| "jsoneditor-react": "^3.1.0", | |||
There was a problem hiding this comment.
nl0
reviewed
Mar 10, 2021
| @@ -0,0 +1,3 @@ | |||
| .jsoneditor.jsoneditor { | |||
There was a problem hiding this comment.
btw this can be scoped to the actual component requiring these overrides just by adding smth like this to the relevant makeStyles call:
root: {
'& .jsoneditor': {
...overrides
}
}
|
I've stuck with unit-tests here, just added the simplest unit-test for React Component Also, I want to add Documentation in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #2087
TODO