Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove packaging from dependencies #2090

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Conversation

sir-sigurd
Copy link
Member

Seems to be unused since
2744c12

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #2090 (013e93a) into master (99ece37) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2090   +/-   ##
=======================================
  Coverage   46.29%   46.29%           
=======================================
  Files         408      408           
  Lines       19475    19475           
  Branches     2258     2258           
=======================================
  Hits         9016     9016           
  Misses       9449     9449           
  Partials     1010     1010           
Flag Coverage Δ
api-python 89.36% <ø> (ø)
catalog 15.78% <ø> (ø)
lambda 92.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/python/setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ece37...013e93a. Read the comment docs.

@sir-sigurd sir-sigurd marked this pull request as ready for review March 5, 2021 08:23
Copy link
Member

@akarve akarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless but @kevinemoore why did you include this 2 years ago?

@sir-sigurd sir-sigurd merged commit 1573486 into master Mar 9, 2021
@sir-sigurd sir-sigurd deleted the cleanup-deps-packaging branch March 9, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants