Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan more bytes when trying to detect vega (128 KiB) #2229

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Jun 22, 2021

TODO

@nl0 nl0 requested a review from akarve June 22, 2021 04:44
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #2229 (28547ca) into master (e4a11af) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 28547ca differs from pull request most recent head 0c9513f. Consider uploading reports for the commit 0c9513f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2229      +/-   ##
==========================================
- Coverage   44.92%   44.92%   -0.01%     
==========================================
  Files         465      465              
  Lines       22990    22991       +1     
  Branches     2859     2859              
==========================================
  Hits        10329    10329              
- Misses      11745    11746       +1     
  Partials      916      916              
Flag Coverage Δ
api-python 89.85% <ø> (ø)
catalog 15.01% <0.00%> (-0.01%) ⬇️
lambda 94.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Preview/loaders/Json.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a11af...0c9513f. Read the comment docs.

@nl0 nl0 merged commit 9a0db96 into master Jun 22, 2021
@nl0 nl0 deleted the detect-vega-better branch June 22, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant