Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle wide vega charts #2304

Merged
merged 7 commits into from
Aug 18, 2021
Merged

Handle wide vega charts #2304

merged 7 commits into from
Aug 18, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 18, 2021

  • Rewrite Vega renderer as a functional component
  • Add overflow scroll for large charts
  • Move dropdown menu to the left, so it doesn't mess with scroll
  • Change character width for JsonDisplay so more likely there won't be a horizontal scroll

@fiskus fiskus requested a review from nl0 August 18, 2021 09:15
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #2304 (d9f9142) into master (bc44db4) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
+ Coverage   44.02%   44.04%   +0.01%     
==========================================
  Files         485      485              
  Lines       23660    23650      -10     
  Branches     3047     3045       -2     
==========================================
  Hits        10416    10416              
+ Misses      12367    12360       -7     
+ Partials      877      874       -3     
Flag Coverage Δ
api-python 89.82% <ø> (ø)
catalog 14.51% <0.00%> (+<0.01%) ⬆️
lambda 93.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/JsonDisplay/JsonDisplay.js 0.00% <0.00%> (ø)
catalog/app/components/Preview/renderers/Vega.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc44db4...d9f9142. Read the comment docs.

@fiskus fiskus merged commit 581e11d into master Aug 18, 2021
@fiskus fiskus deleted the wide-vega branch August 18, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants