Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack for using correct workflow in package name validation #2375

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Oct 14, 2021

I couldn't fix this the right way, so I just mocked schema loading behavior, because when the workflow has a schema for JSON validation, then the workflow is correct

@fiskus fiskus requested a review from nl0 October 14, 2021 18:21
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #2375 (59f839b) into master (b4a1dfb) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2375      +/-   ##
==========================================
- Coverage   43.61%   43.58%   -0.03%     
==========================================
  Files         497      497              
  Lines       23972    23987      +15     
  Branches     3128     3131       +3     
==========================================
  Hits        10455    10455              
- Misses      12699    12714      +15     
  Partials      818      818              
Flag Coverage Δ
api-python 90.27% <ø> (ø)
catalog 14.34% <0.00%> (-0.02%) ⬇️
lambda 93.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bucket/PackageCopyDialog.js 0.00% <0.00%> (ø)
...iners/Bucket/PackageDialog/PackageCreationForm.tsx 0.00% <0.00%> (ø)
...g/app/containers/Bucket/PackageDirectoryDialog.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a1dfb...59f839b. Read the comment docs.

Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this will do

@fiskus fiskus merged commit f444d0a into master Oct 15, 2021
@fiskus fiskus deleted the hack-name-workflow-validation branch October 15, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants