New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User page #323
User page #323
Conversation
|
the error is handled properly on the front-end, but the thing is that the api doesn't return error for the non-existent user, it just returns an empty package list, which doesn't seem correct.
|
done |
i'll rebase this and double-check if everything's ok |
@nl0 branch is approved but you'll need to resolve the conflicts before i can merge |
BTW - API is behaving as expected; please still test the failure case ( |
`owner` prop is required for `PackageHandle`, but we don't always have the owner set on objects in the list, so we need a way to specify their common owner. Also, default `emptyMessage` has been moved to `defaultProps` for consistency.
User page. Branched off of #313, so shouldn't be merged before it.
@akarve @asah pls review
Questions: