Object-level validation, frontend

[fiskus]

• Added one more visible state to files - "invalid"
• Moved entries validation to the function used final-form API (<RF.Field validate={...here...} />)
• Populate Ajv error with entry context data, and then check if there are added or existing files with that error

• Documentation
• Changelog entry (skip if change is not significant to end users, e.g. docs only)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1201258662284091

[codecov]

Codecov Report

Merging #3336 (f9c2a18) into master (e96df90) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3336      +/-   ##
==========================================
+ Coverage   90.71%   90.76%   +0.05%     
==========================================
  Files          34       34              
  Lines        5662     5662              
==========================================
+ Hits         5136     5139       +3     
+ Misses        526      523       -3     

Flag	Coverage Δ
api-python	90.76% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/python/quilt3/data_transfer.py	81.71% <0.00%> (+0.14%)	⬆️
api/python/quilt3/session.py	72.90% <0.00%> (+1.29%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sir-sigurd]

Doc looks OK but might make sense to use logical_key in example to demonstrate how to validate specific object instead of just some object in package.

[nl0]

looks sane.
i'm not quite sure if you're still showing the validation errors "not assigned" to any entries (or are they not expected to be present at all times?). e.g. if you have some error related to several fields or smth like that. also, you only get (.find()) the first error matching entry path, but can there be more than one per path and they are not shown?

[fiskus]

i'm not quite sure if you're still showing the validation errors "not assigned" to any entries

Yes, all entries validation errors are below FilesInput. Unfortunately, they are not very helpful, if you don't know exact JSON Schema. At the same time, I don't show error message in entry. There is a room for improvement here, I address it in the next task.

Probably, it's not so important to invest a lot of time into entries meta validation on frontend

you only get (.find()) the first error matching entry path, but can there be more than one per path and they are not shown?

With .find I only find the fact, the entry is invalid. Actual errors are below the FilesInput block.

[fiskus]

This is not very good UX, of course. For example, if Schema requires README.md with meta, but user provides two files foo.txt and bar.txt, then both files are invalid with two errors each (1. this is not README.md, 2. this doesn't have meta). But actually, files are not invalid, user just need one more file.

[fiskus]

Updated docs: added logical_key