This repository has been archived by the owner on Jun 4, 2019. It is now read-only.
Dashboards + misc browser UI adjustments #8
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d8c80e7
utils/reactTools: createFactory: hoist statics
nl0 257aa2f
utils/AWS/Signer: s3 url signing
nl0 0956c12
app: change AWS service providers order
nl0 9f91195
components/Markdown: pluggable image and link processing
nl0 19ffaf8
Browser: refactor, *dashboards* aka quilt_summarize.json
nl0 05ddb29
Browser: summary stats WIP
nl0 c702957
further work on dashboards feature
nl0 1c5b9bf
package: add ramda
nl0 28c4ad7
utils/reactTools: extractProp helper
nl0 61f06dd
utils/tagged: tagged union constructor
nl0 858c2d1
utils: add AsyncResult, Maybe and Result types
nl0 8808d52
utils: add Resource type / tools
nl0 8a123fa
work on Browser and AWS stuff
nl0 2415b20
package: rm react-modal
nl0 6a84b98
Browser: adjust stat bar color
nl0 d1e8477
Browser: download button
nl0 d58baaa
Browser: adjust preview error text color
nl0 1d52d15
SearchResults: fix link / path
nl0 1e6c33b
Browser: fix overflow on narrow widths
nl0 09f7530
Browser: thumbnails
nl0 32a2715
Browser/Listing: stats: show 0 files / 0 bytes
nl0 b6ce792
Browser: vega spec validation, better error handling
nl0 44d88f3
UserDocs: summaries description
nl0 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks slightly incorrect to me -- I think as it is, this declares a function of 3 parameters, when really you want a function with 1 parameter that has 2 destructure parameters. See "Documenting a destructuring parameter" in http://usejsdoc.org/tags-param.html
Also, if you could document the return type, I would appreciate that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed