-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set hq as the default ALPN protocol in quinn-proto #32
Comments
Hello, I'd like to try to solve this one ! If understand well, this ALPN parameter could be set in endpoint building code like so: builder
.logger(log.clone())
.config(quinn::Config {
max_remote_bi_streams: 64,
alpn_protocols: vec!["hq-11"],
..Default::default()
}).listen(); or let mut builder = quinn::Endpoint::new();
builder.set_alpn_protocols(vec!["hq-11"]); These two options would let a possibility for the the user not to give any ALPN value. Is that desirable, or is it better to make this parameter mandatory? |
Then TLS's ALPN parameter would be left empty when this method has never been called ? |
Yeah, I think that would be okay for some use cases, but I'll await the other reviewer. |
Yes, to the best of my knowledge ALPN is an optional part of the handshake. |
Thank you both for all the time spent reviewing and helping ! |
Leave this to higher API levels to decide.
The text was updated successfully, but these errors were encountered: