Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-protection option in perf crate #1550

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

aochagavia
Copy link
Contributor

While profiling stuff with perf_server and perf_client, I discovered that the no-protection option was not working as expected (it did not disable packet encryption / decryption, as my flamegraphs revealed). It looks like the original feature did disable encryption after a key update, but forgot to do so right after the handshake. This PR fixes that.

In case you are curious, you can observe the problem by running the following commands:

  1. cargo run --release --bin perf_server
  2. cargo run --release --bin perf_client -- --no-protection
  3. Watch the server and the client happily exchange packets (instead of failing to connect because of the mismatch in encryption)

Sponsored by Stormshield
@Ralith Ralith merged commit 74d3689 into quinn-rs:main Apr 26, 2023
8 checks passed
@djc djc mentioned this pull request May 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants