Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport rustls types #1600

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Reexport rustls types #1600

merged 1 commit into from
Jul 17, 2023

Conversation

jonatanzeidler
Copy link
Contributor

This PR makes quinn reexport all rustls types as discussed in #300. This change helps fix the issue described in this example by allowing it to use the reexported types.

@jonatanzeidler
Copy link
Contributor Author

Please check whether reexporting all of rustls is what we want, as well as whether the location and reexport name make sense to you.

@Ralith
Copy link
Collaborator

Ralith commented Jul 14, 2023

The convention I've seen elsewhere is to reexport the crate by name at the top level, i.e. pub extern crate rustls; in lib.rs. I think that's a nice clean and intuitive approach.

@jonatanzeidler
Copy link
Contributor Author

Thanks for the hint. I changed it accordingly, but opted for the pub use syntax, which was already used for the udp crate, too.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ralith Ralith merged commit 0ae7c60 into quinn-rs:main Jul 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants