Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 0.10.x: Reduce default maximum UDP payload size to the ethernet MTU #1620

Conversation

lijunwangs
Copy link
Contributor

Drastically reduces the size and sparsity of the quinn receive buffer for no performance cost in typical applications.

Drastically reduces the size and sparsity of the quinn receive buffer
for no performance cost in typical applications.
@lijunwangs
Copy link
Contributor Author

@Ralith @djc This is backport for 89ff085 into 0.10.x

@Ralith Ralith merged commit 023f103 into quinn-rs:0.10.x Jul 31, 2023
8 checks passed
@lijunwangs
Copy link
Contributor Author

Hi @Ralith and @djc, as this issue is fixed in 0.10.x -- can we publish a new version (0.10.2)?

@djc
Copy link
Collaborator

djc commented Aug 1, 2023

@Ralith how do you feel about releasing this in a semver-compatible release? I suppose it has the potential to break users who were relying on the new behavior (though that might only be the party who asked us to implement it in the first place).

@Ralith
Copy link
Collaborator

Ralith commented Aug 1, 2023

though that might only be the party who asked us to implement it in the first place

Were they using an extra-large interface MTU?

I don't think this is breaking. At worst it will be a fixable performance regression for anyone who was employing jumbo frames or similar, and I'd be a bit surprised if anyone actually was.

@djc
Copy link
Collaborator

djc commented Aug 1, 2023

Hmm, I guess it was just from #1529, so there wasn't really a user pushing this.

@djc
Copy link
Collaborator

djc commented Aug 2, 2023

Published quinn-proto 0.10.2 and quinn 0.10.2.

@lijunwangs
Copy link
Contributor Author

Published quinn-proto 0.10.2 and quinn 0.10.2.

Thanks @djc can we add a tag in the branch as well?

@djc
Copy link
Collaborator

djc commented Aug 2, 2023

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants