Propagate current tracing span to spawned connection drivers #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
approved these changes
Aug 17, 2023
djc
reviewed
Aug 17, 2023
Ralith
force-pushed
the
connection-task-spans
branch
from
f57bb29
to
a02348d
Compare
djc
approved these changes
Aug 21, 2023
For clients, this is the span that was current when the connection attempt was initiated; for servers, it is the span of the endpoint task, which is the span that was current when the endpoint was constructed.
These must enclose the endpoint construction and connect calls.
Ralith
force-pushed
the
connection-task-spans
branch
from
a02348d
to
abf5f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #1616, which finally lets us get easily intelligible interleaved logs for single-process tests.