proto: don't panic when draining an unknown connection #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
defensive-drain
branch
from
511beff
to
76f37b4
Compare
A panic here was reported by a user when testing under very scarce CPU conditions. The root cause is not yet well understood (perhaps a connection emitting `Drained` twice for some reason?), but we can still reduce the blast radius.
Ralith
force-pushed
the
defensive-drain
branch
from
76f37b4
to
ad4be45
Compare
Ralith
changed the title
djc
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A panic here was reported by a user when testing under very scarce CPU conditions. The root cause is not yet well understood (perhaps a connection emitting
Drainedtwice for some reason?), but we can still reduce the blast radius.