Make quinn-proto::{Connection, Endpoint} deterministic
#1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`quinn-proto::{Connection, Endpoint}` structs call
`StdRng::from_entropy()` in their implementation. It makes it hard to
reproduce errors in an otherwise deterministic test case.
This PR addresses the issue by adding a `StdRng` argument to the
respective `new` functions. For other functions that may create an
endpoint/connection, an argument of type `impl FnOnce() -> StdRng` is
added. This avoids eager calls to generate fresh entropy. e.g. the
`Endpoint::handle` function is frequently called but we'd only need the
rng when handling a new incoming connection.
Fixes lint errors.
michael-yxchen
force-pushed
the
seeded-rng
branch
from
b9c205e
to
3748e1e
Compare
Ralith
requested changes
Oct 19, 2023
michael-yxchen
force-pushed
the
seeded-rng
branch
from
85a93d1
to
166752b
Compare
|
Put up another version that always use |
Ralith
requested changes
Oct 20, 2023
djc
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quinn-proto::{Connection, Endpoint}structs callStdRng::from_entropy()in their implementation. It makes it hard to reproduce errors in an otherwise deterministic test case.This PR addresses the issue by adding a
StdRngargument to the respectivenewfunctions. For other functions that may create an endpoint/connection, an argument of typeimpl FnOnce() -> StdRngis added. This avoids eager calls to generate fresh entropy. e.g. theEndpoint::handlefunction is frequently called but we'd only need the rng when handling a new incoming connection.Fixes an unrelated lint error.
Closes #1684