Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break linkability on client-side after planned migration #1800

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

nemethf
Copy link
Contributor

@nemethf nemethf commented Apr 2, 2024

The server switches to a new CID as well, but it sends a path-challenge on the old path with the new CID. So it is still possible to trace back the connection to the old path after the client switches to a new socket.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Please open a separate issue for the server-side bug if you don't plan to address it immediately yourself.

quinn/src/lib.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
@Ralith
Copy link
Collaborator

Ralith commented Apr 4, 2024

Tweaked to encapsulate update_rem_cid inside a higher level, more semantic API at the proto layer.

@Ralith Ralith enabled auto-merge (rebase) April 4, 2024 03:21
@Ralith Ralith merged commit e28a7f2 into quinn-rs:main Apr 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants