Fix minor datagram send bugs #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
datagram-cleanup
branch
from
1cd5085
to
a08251c
Compare
djc
approved these changes
Apr 29, 2024
Ralith
force-pushed
the
datagram-cleanup
branch
from
fae273a
to
79246f5
Compare
Prevents spans from leaking when packets aren't finished
The current system time must only be sampled once to establish the unit test epoch. Because test time doesn't advance unless told to, this was causing connections to sometimes receive packets from before they were created, causing odd warnings and potentially other unintended behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while exploring solutions to #1832. Also tossing in any other simple wins I stumble across.