Clarify Connection::space_can_send logic #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
can-send-acks
branch
2 times, most recently
from
b007489
to
c56bac4
Compare
Ralith
changed the title
|
Testing and re-examination reveals that this doesn't actually change any behavior, because if ACKs were sendable then |
djc
reviewed
May 8, 2024
When this check fails, indicating that `can_send == SendableFrames::empty()`, we return `SendableFrames::empty()` anyway.
djc
approved these changes
May 12, 2024
|
Much easier to review, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.