Defragment incoming stream chunks (fixes #431) #598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an attempt at solving that old memory fragmentation issue. The 32 threshold is just a simple heuristic: in the worst case we accept 32 1-byte chunks from 32 different datagrams, 32k of unnecessary allocations, but hopefully most applications would not get up to 32 chunks in the buffer so that they would not trigger the (relatively slow) defragmentation code.
Let me know what you think!