Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Total energy monitor for dg #460

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Total energy monitor for dg #460

merged 4 commits into from
Nov 25, 2020

Conversation

adityakpandare
Copy link
Member

@adityakpandare adityakpandare commented Nov 24, 2020 •
edited by jbakosi
Loading

Implemented a total energy monitor in the diagnostic file for dg; changed the ndiff config files to skip this total energy column while testing the diagnostic files.

This change is Reviewable

jbakosi
jbakosi approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@jbakosi jbakosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this. Yeah, I suspect std::cout was failing in SMP because, that is not thread-safe in general. Good to go!

Reviewed 13 of 14 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

adityakpandare
adityakpandare commented Nov 25, 2020
View reviewed changes
Copy link
Member Author

@adityakpandare adityakpandare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I missed that. Thanks for the quick review!

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

jbakosi
jbakosi approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@jbakosi jbakosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Can you please also merge branch output_clang? Thanks.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

adityakpandare
adityakpandare commented Nov 25, 2020
View reviewed changes
Copy link
Member Author

@adityakpandare adityakpandare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I just have to wait for Azure to pass the branch correct? No other requirements to merge?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@adityakpandare adityakpandare merged commit 982362f into develop Nov 25, 2020
@adityakpandare adityakpandare deleted the totenergy_dg branch November 25, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbakosi jbakosi jbakosi approved these changes

Assignees
No one assigned
Labels
inciter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityakpandare @jbakosi