Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart dependencies with conditions are cleared when running suite #60

Closed
longgerr opened this issue Sep 2, 2020 · 0 comments · Fixed by #61
Closed

Chart dependencies with conditions are cleared when running suite #60

longgerr opened this issue Sep 2, 2020 · 0 comments · Fixed by #61
Assignees

Comments

@longgerr
Copy link

longgerr commented Sep 2, 2020

When we use dependencies with conditions like the following example, the dependencies which doesn't meet the conditions will be deleted from the Chart object, and won't be reloaded in the next test case's run.

dependencies:
  - name: mysql
    repository: https://kubernetes-charts.storage.googleapis.com
    version: 1.2.0
    condition: mysql.enabled
  - name: redis
    repository: https://kubernetes-charts.storage.googleapis.com
    version: 10.5.7
    condition: redis.enabled

Fix:
Chart's dependencies should be kept before each test's run, and recover after the run to make sure the next test run has the correct dependencies loaded

@quintush quintush self-assigned this Sep 7, 2020
quintush added a commit that referenced this issue Sep 7, 2020
Fix issue #60: Chart dependencies with conditions are cleared when running test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants