Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for rho auth add command #12

Merged
merged 4 commits into from
Aug 11, 2017
Merged

Add tests for rho auth add command #12

merged 4 commits into from
Aug 11, 2017

Conversation

elyezer
Copy link
Contributor

@elyezer elyezer commented Aug 11, 2017

Added some commits to get the initial test scenarios for rho auth * commands automated:

  • Created a context manager to help creating a temporary directory. This will help ensure that the data directory created by RHO gets created and removed for every test.
  • Added a py.test fixture which makes use of the isolated_filesystem context manager. Now whenever a test function has the isolated_filesystem argument py.test will automatically run the context manager and generate/remove the temporary directory.
  • Added pexpect as a requirement it will help running RHO and filling its inputs like the vault password.
  • Finally with all the above in place, we are able to automate some test cases. These automated tests should cover the happy path and some negative tests for the rho auth * commands.

Closes #5

The context manager helps changing the current working directory to a
temporary directory that will be removed later.
The test fixture helps changing the current working directory to a
temporary directory that will be removed later.
@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage decreased (-71.5%) to 16.498% when pulling 48afeaa on issues/5 into f7105b9 on master.

@elyezer elyezer merged commit 48afeaa into master Aug 11, 2017
@elyezer elyezer deleted the issues/5 branch August 11, 2017 18:37
@elyezer
Copy link
Contributor Author

elyezer commented Aug 11, 2017

ae3d149 fixes the coverage decrease, we are interested on measuring coverage only for the camayoc framework not the tests for rho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tests for rho auth * commands
3 participants