Fix CLI tests to allow for new config data #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elyezer
approved these changes
Feb 20, 2018
camayoc/tests/qcs/cli/utils.py
Outdated
| @@ -47,6 +47,9 @@ def cred_add(options, inputs=None, exitstatus=0): | |||
| """ | |||
| if 'type' not in options: | |||
| options['type'] = 'network' | |||
| if options.get('rho'): | |||
There was a problem hiding this comment.
This could be a oneliner: options.pop('rho', None)
There was a problem hiding this comment.
ah cool I'll do that
Updated rho tests to use the same config file format as quipucords, but forgot to update qpc CLI tests to not use an extra field created to guard rho tests from using some credentials.
kdelee
force-pushed
the
kdelee/fix-cred-add
branch
from
d8a495d
to
3858de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated rho tests to use the same config file format as quipucords, but forgot
to update qpc CLI tests to not use an extra field created to guard rho tests
from using some credentials.