Add initial UI test #151
Merged
Add initial UI test #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems I need to write some tests for camayoc, I am going to work on that later. Feel free to review as I should only add the tests later. |
kdelee
approved these changes
Feb 20, 2018
| login.password.fill('pass') | ||
| login.login.click() | ||
|
|
||
| assert browser.selenium.title == 'Red Hat Entitlements Reporting' |
There was a problem hiding this comment.
Maybe make this a constant in constants.py?
| assert browser.selenium.title == 'Red Hat Entitlements Reporting' | ||
|
|
||
| dashboard = DashboardView(browser) | ||
| dashboard.user_dropdown.select_item('Logout') |
There was a problem hiding this comment.
See above comment.
I'm not certain this is better. Maybe even there should be a separate UI constants file, because there will probably be lots of text we will be working with.
There was a problem hiding this comment.
I think for now I will leave the string here. As UI test grows we decide if we would have a constants file for it or not.
Close #106
|
I will wait for travis and coveralls and if they are happy will merge the PR. I've added tests for the new util function to fetch the base URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #106