Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyvmomi package to dev requirements #31

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Add pyvmomi package to dev requirements #31

merged 1 commit into from
Sep 20, 2017

Conversation

kdelee
Copy link
Contributor

@kdelee kdelee commented Sep 15, 2017

Forgot this key part of making this work on someone else's machine 😬

@kdelee kdelee requested a review from elyezer September 15, 2017 22:30
@coveralls
Copy link

coveralls commented Sep 15, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 77.907% when pulling 92064b3 on kdelee:issues/30 into ba0d487 on quipucords:master.

@kdelee
Copy link
Contributor Author

kdelee commented Sep 20, 2017

@elyezer I moved these requirements to the regular install requires section because they are needed to run tests under the camayoc module.

If you are still good I'll merge it so I can move forward with Jenkins testing

@kdelee
Add pyvmomi package to install requirements
f803661 
Also adds pytest package to install requirements, both needed by remote
scan tests.

Closes quipucords#30
@coveralls
Copy link

coveralls commented Sep 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 77.907% when pulling 8d2f162 on kdelee:issues/30 into be75912 on quipucords:master.

@coveralls
Copy link

coveralls commented Sep 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 77.907% when pulling f803661 on kdelee:issues/30 into be75912 on quipucords:master.

@elyezer
Copy link
Contributor

elyezer commented Sep 20, 2017

Looks great, please ship it

@kdelee kdelee merged commit 632bffd into quipucords:master Sep 20, 2017
@kdelee kdelee deleted the issues/30 branch September 20, 2017 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elyezer elyezer elyezer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdelee @coveralls @elyezer