Poll remote servers until live. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elyezer
suggested changes
Sep 20, 2017
camayoc/tests/remote/conftest.py
Outdated
| ping. Keep trying until a connection is made for all servers or the timeout | ||
| limit is reached. | ||
| """ | ||
| from camayoc import cli |
There was a problem hiding this comment.
Please move this import to the top of the file.
There was a problem hiding this comment.
Actually you can add a new item to line 5:
from camayoc import cli, config
elyezer
suggested changes
Sep 20, 2017
camayoc/tests/remote/conftest.py
Outdated
| unreached = [host for host in unreached if not is_live(client, host)] | ||
| sleep(10) | ||
| timeout -= 10 | ||
| return |
| client = cli.Client(system) | ||
|
|
||
| unreached = servers | ||
| while unreached and timeout > 0: |
There was a problem hiding this comment.
What should happen when the timeout is over and still some unreached hosts?
It takes time between the power on signal is sent to the remote servers and they are available over ssh for rho. These changes make it so servers are polled until they respond or a timeout limit is reached. Closes #28
elyezer
approved these changes
Sep 20, 2017
| Keep trying until a connection is made for all servers or the timeout | ||
| limit is reached. | ||
|
|
||
| If the timeout limit is reached, we exit even if there are unreached hosts. |
|
@elyezer thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes time between the power on signal is sent to the remote servers
and they are available over ssh for rho. These changes make it so
servers are polled until they respond or a timeout limit is reached.
Closes #28