Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Commit

Permalink
Fix various lint issues (#29)
Browse files Browse the repository at this point in the history
* Improve code styling and doc by fixing lint issues. Fixed all flake8 issues and added to make lint. Closes #22.

* resolve lint errors. disable some checks for later evaluation.

* Fix lint errors associated with python 2 v python3 support.

* Code review comment updates.
  • Loading branch information
chambridge committed Jun 26, 2017
1 parent 63de6cf commit 109cc24
Show file tree
Hide file tree
Showing 16 changed files with 591 additions and 474 deletions.
5 changes: 2 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ lint-flake8:
flake8 . --ignore D203

lint-pylint:
-for d in $(PYDIRS); do PYTHONPATH=$(TOPDIR)/src pylint $$d/*.py; done
-PYTHONPATH=$(TOPDIR)/src pylint bin/rho
pylint */*.py

lint: lint-pylint
lint: lint-flake8 lint-pylint
1 change: 0 additions & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ These python packages are required for the rho install machine to run rho:
* subprocess
* xmlrpclib
* ansible.module_utils.basic
* babel

The following python packages are required to build & test rho from source:
* python-devel
Expand Down
Loading

0 comments on commit 109cc24

Please sign in to comment.