Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Fix linting issues #22

Closed
chambridge opened this issue Jun 16, 2017 · 1 comment
Closed

Fix linting issues #22

chambridge opened this issue Jun 16, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@chambridge
Copy link

Fix linting issues:

************* Module rho.cli
C: 49, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C: 50, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C: 21, 0: Invalid constant name "t" (invalid-name)
C: 25, 0: Missing class docstring (missing-docstring)
C: 25, 0: Old-style class defined. (old-style-class)
C: 87, 4: Missing method docstring (missing-docstring)
R: 25, 0: Too few public methods (1/2) (too-few-public-methods)
C: 20, 0: standard import "import gettext" should be placed before "import rho.clicommands" (wrong-import-order)
************* Module rho.clicommands
C:375, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:563, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:705, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:708, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:761, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:792, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:851, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:960, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:963, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:1045, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:1157, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C:  1, 0: Too many lines in module (1192/1000) (too-many-lines)
W: 95, 0: Anomalous backslash in string: '\['. String constant might be missing an r prefix. (anomalous-backslash-in-string)
W: 95, 0: Anomalous backslash in string: '\]'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
W: 96, 0: Anomalous backslash in string: '\['. String constant might be missing an r prefix. (anomalous-backslash-in-string)
W: 96, 0: Anomalous backslash in string: '\]'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
W: 98, 0: Anomalous backslash in string: '\['. String constant might be missing an r prefix. (anomalous-backslash-in-string)
W: 98, 0: Anomalous backslash in string: '\]'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
W:100, 0: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
W:185, 0: Anomalous backslash in string: '\['. String constant might be missing an r prefix. (anomalous-backslash-in-string)
W:185, 0: Anomalous backslash in string: '\]'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
C: 29, 0: Invalid constant name "t" (invalid-name)
C: 35, 0: Missing function docstring (missing-docstring)
C: 36, 4: Missing function docstring (missing-docstring)
W: 36,21: Unused argument 'opt_str' (unused-argument)
W: 36,30: Unused argument 'value' (unused-argument)
C: 49, 0: Missing function docstring (missing-docstring)
W: 49,22: Unused argument 'opt_str' (unused-argument)
W: 49,31: Unused argument 'value' (unused-argument)
C: 79,29: Invalid variable name "e" (invalid-name)
C: 87,42: Invalid variable name "f" (invalid-name)
C:103, 8: Invalid variable name "r" (invalid-name)
C:128, 9: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
C:137,54: Invalid variable name "f" (invalid-name)
C:153,52: Invalid variable name "f" (invalid-name)
C:160, 8: Invalid variable name "f" (invalid-name)
R:176, 0: Too many local variables (23/15) (too-many-locals)
C:184, 8: Invalid variable name "r" (invalid-name)
C:186, 8: Invalid variable name "r" (invalid-name)
C:198, 8: Invalid variable name "a" (invalid-name)
C:199, 8: Invalid variable name "f" (invalid-name)
C:237,43: Invalid variable name "f" (invalid-name)
C:242, 8: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
C:242,12: Invalid variable name "l" (invalid-name)
C:264,64: Invalid variable name "f" (invalid-name)
C:276,12: Invalid variable name "h" (invalid-name)
C:276,15: Invalid variable name "l" (invalid-name)
C:278,16: Invalid variable name "a" (invalid-name)
C:295, 8: Invalid variable name "h" (invalid-name)
C:299,52: Invalid variable name "f" (invalid-name)
C:300,12: Invalid variable name "a" (invalid-name)
C:312,16: Invalid variable name "h" (invalid-name)
R:333, 0: Too few public methods (1/2) (too-few-public-methods)
W:366,23: Attribute 'args' defined outside __init__ (attribute-defined-outside-init)
W:370, 8: Attribute 'args' defined outside __init__ (attribute-defined-outside-init)
W:366, 9: Attribute 'options' defined outside __init__ (attribute-defined-outside-init)
R:443, 4: Too many local variables (24/15) (too-many-locals)
C:462,43: Invalid variable name "f" (invalid-name)
C:470,24: Invalid variable name "a" (invalid-name)
C:471,24: Invalid variable name "a" (invalid-name)
C:472,62: Invalid variable name "g" (invalid-name)
C:496,15: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
R:382, 0: Too few public methods (1/2) (too-few-public-methods)
C:553,43: Invalid variable name "f" (invalid-name)
R:527, 0: Too few public methods (1/2) (too-few-public-methods)
C:582,43: Invalid variable name "f" (invalid-name)
R:567, 0: Too few public methods (1/2) (too-few-public-methods)
R:629, 4: Too many local variables (23/15) (too-many-locals)
C:641,15: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
C:649,43: Invalid variable name "f" (invalid-name)
C:652,46: Invalid variable name "g" (invalid-name)
C:655,43: Invalid variable name "f" (invalid-name)
C:670,28: Invalid variable name "r" (invalid-name)
C:680,28: Invalid variable name "a" (invalid-name)
R:656,12: Too many nested blocks (6/5) (too-many-nested-blocks)
R:629, 4: Too many branches (15/12) (too-many-branches)
R:629, 4: Too many statements (52/50) (too-many-statements)
R:588, 0: Too few public methods (1/2) (too-few-public-methods)
C:748,47: Invalid variable name "f" (invalid-name)
C:751,47: Invalid variable name "f" (invalid-name)
C:783,16: Invalid variable name "fl" (invalid-name)
R:711, 0: Too few public methods (1/2) (too-few-public-methods)
C:843,47: Invalid variable name "f" (invalid-name)
C:856,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
C:864,16: Invalid variable name "a" (invalid-name)
C:866,54: Invalid variable name "f" (invalid-name)
C:880,43: Invalid variable name "f" (invalid-name)
R:795, 0: Too few public methods (1/2) (too-few-public-methods)
C:939,46: Invalid variable name "f" (invalid-name)
C:942,46: Invalid variable name "f" (invalid-name)
R:889, 0: Too few public methods (1/2) (too-few-public-methods)
C:998,50: Invalid variable name "fr" (invalid-name)
C:999,52: Invalid variable name "tw" (invalid-name)
C:1003,48: Invalid variable name "tr" (invalid-name)
C:1004,54: Invalid variable name "fw" (invalid-name)
R:966, 0: Too few public methods (1/2) (too-few-public-methods)
C:1049,46: Invalid variable name "f" (invalid-name)
R:1019, 0: Too few public methods (1/2) (too-few-public-methods)
C:1088,46: Invalid variable name "f" (invalid-name)
R:1070, 0: Too few public methods (1/2) (too-few-public-methods)
C:1153,50: Invalid variable name "f" (invalid-name)
R:1103, 0: Too few public methods (1/2) (too-few-public-methods)

------------------------------------------------------------------
Your code has been rated at 8.42/10 (previous run: 8.42/10, +0.00)
@chambridge chambridge added the bug label Jun 16, 2017
@chambridge chambridge self-assigned this Jun 22, 2017
@chambridge chambridge added this to the Sprint 1 milestone Jun 22, 2017
chambridge added a commit that referenced this issue Jun 23, 2017
@chambridge
Copy link
Author

#29

chambridge added a commit that referenced this issue Jun 26, 2017
* Improve code styling and doc by fixing lint issues. Fixed all flake8 issues and added to make lint. Closes #22.

* resolve lint errors. disable some checks for later evaluation.

* Fix lint errors associated with python 2 v python3 support.

* Code review comment updates.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant