This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Add path options to fact encrypt, decrypt, and redact #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let users specify the path to write the encrypted, decrypted, or redacted file to. If not given, default to not overwriting the original report file.
chambridge
reviewed
Aug 30, 2017
rho/factdecryptcommand.py
Outdated
|
|
||
| self.parser.add_option("--decrypted-path", dest="decrypted_path", | ||
| metavar="DECRYPTEDPATH", | ||
| help=_("Location for the decrypted file")) |
There was a problem hiding this comment.
Should use consistent working this is different than encryption help:
Destination for the encrypted file
There was a problem hiding this comment.
I think all the new option could be named the same --path or --destinationfile or --somethingbetter. The subcommand would already provide the context if the user is encrypt, decrypt or redact.
rho/factredactcommand.py
Outdated
|
|
||
| self.parser.add_option("--redacted-path", dest="redacted_path", | ||
| metavar="REDACTEDPATH", | ||
| help=_("Path to write the redacted report to")) |
There was a problem hiding this comment.
Similar help consistency wording would be nice here.
chambridge
approved these changes
Aug 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let users specify the path to write the encrypted, decrypted, or
redacted file to. If not given, default to not overwriting the
original report file.
Closes #247 .