Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overriding jobs during execution should preserve the overridden schedule #180

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Aug 18, 2021

This PR fixes a bug that occurs when a job is overriden during execution. See quirrel-dev/quirrel#739 (comment) for context.

@coveralls
Copy link

coveralls commented Aug 20, 2021

Pull Request Test Coverage Report for Build 1150719846

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 87.105%

Files with Coverage Reduction New Missed Lines %
src/shared/tracer.ts 2 86.67%
src/worker/worker.ts 2 90.71%
Totals Coverage Status
Change from base Build 1138211827: -0.5%
Covered Lines: 435
Relevant Lines: 464

💛 - Coveralls

@Skn0tt Skn0tt merged commit 4340061 into main Aug 20, 2021
@Skn0tt Skn0tt deleted the override-jobs-during-execution branch August 20, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants