Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_dataframe() brakes with nulls in time column #54

Closed
JotaBlanco opened this issue Mar 6, 2023 · 2 comments
Closed

from_dataframe() brakes with nulls in time column #54

JotaBlanco opened this issue Mar 6, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JotaBlanco
Copy link

Tell us about the bug
from_dataframe() conversion seems to break if there are nulls in the time column of the dataframe.

What did you expect to see?
Here, as with any null dealing situation, there is a decision to make:

  • Drop the rows with nulls in the time column:
    dataframe = dataframe.dropna(subset=time_label)

  • Extrapolate the nulls in the time columns using surrounding values:
    dataframe[time_label] = dataframe[time_label].interpolate(method='linear')
@JotaBlanco JotaBlanco mentioned this issue Mar 6, 2023
Closed
@peter-quix
Copy link
Contributor

Thinking best would be to throw an exception rather than silently ommitting // setting an artificial value

@peter-quix peter-quix added bug Something isn't working good first issue Good for newcomers labels Mar 26, 2023
tim-quix pushed a commit that referenced this issue Nov 14, 2023
@tbedford
[Task/30687] - Fix swagger URL (#54)
ce29380 
* [fix] - fix swagger urls and tidy

* [fix] - tidy instructions on how to get swagger docs

* [fix] - remove screenshot not required

* [fix] - case of URL
@peter-quix
Copy link
Contributor

No longer relevant, new python code is not working the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Quix Streams - Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JotaBlanco @peter-quix